[rtg] Bug in targetmaker [WAS: RTG 9]

[Drew Weaver]

Not to thread Hijack, but its impossible to build RTG 0.9 on Redhat 4 or CentOS 4.

Making all in cgilib-0.4
make[1]: Entering directory `/newrtg/rtg/cgilib-0.4'
Makefile:161: .deps/cgi.Po: No such file or directory
make[1]: *** No rule to make target `.deps/cgi.Po'.  Stop.
make[1]: Leaving directory `/newrtg/rtg/cgilib-0.4'
make: *** [all-recursive] Error 1

just sayin.

-Drew

-----Original Message-----
From: rtg-bounces at lists.grdata.com [mailto:rtg-bounces at lists.grdata.com] On Behalf Of Brandon Ewing
Sent: Monday, March 24, 2008 3:49 PM
To: rtg at lists.grdata.com
Subject: Re: [rtg] Bug in targetmaker [WAS: RTG 9]

On Fri, Mar 21, 2008 at 04:34:24PM -0500, Brandon Ewing wrote:
> On Sun, Mar 02, 2008 at 07:19:45AM -0600, Brian T. O'Neill wrote:
> > Let me know what issue's you're seeing please, I'll get them taken
> > care of ASAP.
> >
> > Brian
>
> There appears to be a bug in the CVS version of targetmaker, but I'm
> no perl guru, so I'm having trouble figuring out how to fix it.
>
> Every time I run targetmaker, it always inserts additional rows into
> options_table.  From looking at the code, it appears that it is trying
> to check to see if a row exists, inserting it if it doesn't, and only
> updating if necessary.
>
> Unfortunately, something appears to be going horribly wrong.
>
> Wouldn't it make more sense to replace the whole check, INSERT/UPDATE
> thing with just a REPLACE statement, since it appears there's already
> a key composed of the 3 columns?
>

Attached patch changes options_table.graphname into a primary key, removes the select / insert / update check with a simple REPLACE.

--
Brandon Ewing                                        (nicotine at warningg.com)